fix(android): enable offline video playback with local files#81
Open
maurovitale wants to merge 1 commit intobcc-code:mainfrom
Open
fix(android): enable offline video playback with local files#81maurovitale wants to merge 1 commit intobcc-code:mainfrom
maurovitale wants to merge 1 commit intobcc-code:mainfrom
Conversation
andreasgangso
approved these changes
Jun 6, 2025
Contributor
andreasgangso
left a comment
There was a problem hiding this comment.
Thank you for this!
It looks good to me @sifferhans. Here's the source code for DefaultDataSource: https://github.com/androidx/media/blob/release/libraries/datasource/src/main/java/androidx/media3/datasource/DefaultDataSource.java
maybe just verify that offline urls aren't affected since that's the only special data source for bcc media
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the changes
This PR fixes offline video playback support on Android by updating the upstream data source factory in ExoPlayerController.
Problem: The player was previously using DefaultHttpDataSource.Factory(), which only supports HTTP/HTTPS URLs. This prevented playback of locally cached or downloaded videos using file:// URLs, breaking offline functionality.
Solution: Replace DefaultHttpDataSource.Factory() with DefaultDataSource.Factory(context) which supports multiple protocols including:
HTTP/HTTPS URLs (existing functionality)
Local file:// URLs (new offline support)
Content:// URLs
Asset:// URLs
This change enables the player to handle both online streaming and offline cached/downloaded content seamlessly.
Important files
android/src/main/kotlin/media/bcc/bccm_player/players/exoplayer/ExoPlayerController.kt - Updated upstream data source factory to support local files
Discussion points
This is a critical fix for applications that require offline video playback capabilities. The change is backward compatible and doesn't affect existing HTTP streaming functionality while adding support for local file playback.
Testing: Verify that both HTTP streaming and local file:// playback work correctly after this change.