Implement widevine drm protected content#77
Open
kxgcayh wants to merge 9 commits intobcc-code:mainfrom
Open
Conversation
andreasgangso
suggested changes
Feb 14, 2025
Contributor
There was a problem hiding this comment.
Cool! Thanks for contributing back. I see a few necessary tweaks so I'm throwing in a review here. But @sifferhans is the maintainer now
| playerView.findViewById<View?>(R.id.exo_progress)?.visibility = View.GONE | ||
| playerView.findViewById<View?>(R.id.exo_time)?.visibility = View.GONE | ||
| // playerView.findViewById<View?>(R.id.exo_progress)?.visibility = View.GONE | ||
| // playerView.findViewById<View?>(R.id.exo_time)?.visibility = View.GONE |
Contributor
There was a problem hiding this comment.
Prefer deleting code instead of commenting
example/android/app/build.gradle
Outdated
| namespace = "media.bcc.bccm_player_example" | ||
| compileSdkVersion flutter.compileSdkVersion | ||
| ndkVersion flutter.ndkVersion | ||
| ndkVersion "27.0.12077973" |
Comment on lines
329
to
331
| if (player.playbackState == Player.STATE_ENDED) { | ||
| return PlaybackPlatformApi.PlaybackState.STOPPED | ||
| } |
Contributor
There was a problem hiding this comment.
seems unnecessary. its already handled by
!arrayOf(
Player.STATE_ENDED,
Player.STATE_IDLE
).contains(player.playbackState) ```
sifferhans
previously approved these changes
Jun 12, 2025
Author
|
please check my latest commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the changes
Now you can play protected content on Android
Important files
Updated file:
playback_platform_pigeon.dartPlayerController.ktatreplaceCurrentMediaItem()Discussion points