PoC: Add linter/static analysis for the project#4
Open
maxkrivich wants to merge 3 commits intobbl:mainfrom
Open
PoC: Add linter/static analysis for the project#4maxkrivich wants to merge 3 commits intobbl:mainfrom
maxkrivich wants to merge 3 commits intobbl:mainfrom
Conversation
Owner
|
Looks great! Appreciate your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR I just want to raise some concerns about code quality in the project, so I'd kindly ask you to merge it to a separate branch and fix some linter error to have for the future development of the plugin. Also, I've updated a
Makefileto have a nicer help message and etc.This tool has a lot of features and pretty good documentation which help you to set everything up.
https://golangci-lint.run/
DO NOT merge it into the master yet, until I fix the config, or feel free to help me out with this. I look forward to your response.