fix: validate node_version[_from_nvmrc] consistently #3888
+46
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
3887-dirs
branch
3 times, most recently
from
6814536 to
3f678e2
Compare
|
jbedard
force-pushed
the
3887-dirs
branch
9 times, most recently
from
182ac64 to
716bc18
Compare
alexeagle
approved these changes
Dec 23, 2025
jbedard
force-pushed
the
3887-dirs
branch
2 times, most recently
from
0d9166d to
5f42b37
Compare
jbedard
changed the title
jbedard
commented
Jan 5, 2026
| if not node_repositories.items(): | ||
| node_repositories = NODE_VERSIONS | ||
|
|
||
| # Skip the download if we know it will fail |
Collaborator
Author
There was a problem hiding this comment.
So we would skip it and not fail... why? Then _prepare_node would be invoked and generate all the extra bin files despite node never been downloaded and extracted...
alan-agius4
reviewed
Jan 6, 2026
Co-authored-by: Alan Agius <alan.agius4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3887
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
node_version_from_nvmrcvalidation is not performed and the download macro exits early without error and without downloading+extracting node.Issue Number: #3887
What is the new behavior?
The
node_versionandnode_version_from_nvmrcvalidation is aligned and fail the same.Does this PR introduce a breaking change?
Other information