autotools: improve version detection and add download from alpha URLs#24
Draft
autotools: improve version detection and add download from alpha URLs#24
Conversation
This commit adds two improvements to Autotools matching: - Flexible version detection: Replaces restrictive numeric-only regex patterns (`\d+(?:\.\d+)*`) with flexible patterns (`\S+`). This enables detection of complex version formats like git-based versions (2.4.6.42-b88ce-dirty) and alpha/beta versions (1.16b). - Downloads from alpha-version URLs: some source archives (tarballs) are built with alpha/beta versions of Autotools. These versions of Autotools are hosted on a separate website, so we need to add this fallback URL to download those archives too. As a consequence, we validated the sudo package in Amazon Linux 2023 with a tarball sudo-1.9.15p5.tar.gz uses Autoconf 2.72c from the alpha-version URL. This Autoconf version required additional packages to be installed: hostname and perl-Time-HiRes. Thus, we updated the misc/ Dockerfiles. The current Autotools matching logic still cannot do two things: - Download and install git-based versions, and - Apply downstream patches (other than an ad-hoc `runstatedir` backport in Autoconf 2.69). These will be fixed in follow-up commits. Signed-off-by: Dmitrii Kuvaiskii <dimakuv@amazon.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds two improvements to Autotools matching:
Flexible version detection: Replaces restrictive numeric-only regex patterns (
\d+(?:\.\d+)*) with flexible patterns (\S+). This enables detection of complex version formats like git-based versions (2.4.6.42-b88ce-dirty) and alpha/beta versions (1.16b).Downloads from alpha-version URLs: some source archives (tarballs) are built with alpha/beta versions of Autotools. These versions of Autotools are hosted on a separate website, so we need to add this fallback URL to download those archives too.
As a consequence, we validated the sudo package in Amazon Linux 2023 with a tarball sudo-1.9.15p5.tar.gz uses Autoconf 2.72c from the alpha-version URL. This Autoconf version required additional packages to be installed: hostname and perl-Time-HiRes. Thus, we updated the misc/ Dockerfiles.
The current Autotools matching logic still cannot do two things:
runstatedirbackport in Autoconf 2.69).These will be fixed in follow-up commits.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.