Fix data channel data races and globally shared plugin state#105
Open
saligrama wants to merge 2 commits intoaws:mainlinefrom
Open
Fix data channel data races and globally shared plugin state#105saligrama wants to merge 2 commits intoaws:mainlinefrom
saligrama wants to merge 2 commits intoaws:mainlinefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Currently, the data channel has several concurrent goroutines that modify shared data. When running under the Go race detector
go run -race, multiple warnings are fired about data races pertaining to the data channel. Moreover, the session registry holds one live instance of each session type (shell / port), meaning that when using the plugin as a library and trying to open multiple sessions at a time, these sessions overwrite each other's data.Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.