Skip to content

Upgrade Surefire#597

Merged
darklight3it merged 8 commits intomainfrom
dmelfi/upgrade-surefire
Mar 24, 2026
Merged

Upgrade Surefire#597
darklight3it merged 8 commits intomainfrom
dmelfi/upgrade-surefire

Conversation

@darklight3it
Copy link
Contributor

@darklight3it darklight3it commented Mar 24, 2026

Issue #, if available:

Description of changes:

After the recent Jackson upgrade, tests in several modules were silently not running because we have not updated Surefire. This plugin is used by maven for the discovery and runnning of the tests and must be paired with specific junit version.

Downgraded to JUnit 5.12.2 (platform 1.12.2) to align with surefire's bundled platform version. Because 5.14.3 breaks the compatibility matrix below.

I also added a check that will make the test run fail if no tests are run, in order to catch similar problems in the future.

Surefire / JUnit Platform compatibility

Surefire Bundled Platform Compatible JUnit Jupiter Min Java
3.5.x 1.12.x 5.12.x 8
3.4.x 1.11.x 5.11.x 8
3.3.x 1.10.x 5.10.x 8
3.2.x 1.9.x 5.9.x 8

Target (OCI, Managed Runtime, both): both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@darklight3it darklight3it requested a review from M-Elsaeed March 24, 2026 00:19
@darklight3it darklight3it changed the title build: upgrade surefire Upgrade Surefire Mar 24, 2026
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.38%. Comparing base (d8ffbf1) to head (d322b5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #597   +/-   ##
=========================================
  Coverage     65.38%   65.38%           
  Complexity      211      211           
=========================================
  Files            34       34           
  Lines           988      988           
  Branches        142      142           
=========================================
  Hits            646      646           
  Misses          290      290           
  Partials         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darklight3it darklight3it merged commit 09c4b4e into main Mar 24, 2026
13 checks passed
@darklight3it darklight3it deleted the dmelfi/upgrade-surefire branch March 24, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants