Open
Conversation
karenc-bq
force-pushed
the
feat/gdb-rw-splitting
branch
from
d936dfc to
f65c937
Compare
karenc-bq
force-pushed
the
feat/gdb-failover
branch
5 times, most recently
from
5b7069a to
14c1bb3
Compare
sophia-bq
reviewed
Mar 16, 2026
common/lib/plugins/read_write_splitting/abstract_read_write_splitting_plugin.ts
Outdated
Show resolved
Hide resolved
common/lib/plugins/read_write_splitting/gdb_read_write_splitting_plugin.ts
Show resolved
Hide resolved
karenc-bq
force-pushed
the
feat/gdb-rw-splitting
branch
from
f65c937 to
0f2e4d4
Compare
common/lib/plugins/read_write_splitting/read_write_splitting_plugin_factory.ts
Show resolved
Hide resolved
common/lib/plugins/read_write_splitting/gdb_read_write_splitting_plugin.ts
Show resolved
Hide resolved
common/lib/plugins/read_write_splitting/gdb_read_write_splitting_plugin.ts
Show resolved
Hide resolved
common/lib/plugins/read_write_splitting/gdb_read_write_splitting_plugin.ts
Show resolved
Hide resolved
common/lib/plugins/read_write_splitting/gdb_read_writer_splitting_plugin.ts
Outdated
Show resolved
Hide resolved
common/lib/plugins/read_write_splitting/read_write_splitting_plugin.ts
Outdated
Show resolved
Hide resolved
karenc-bq
force-pushed
the
feat/gdb-rw-splitting
branch
from
02faa19 to
dc5e100
Compare
sophia-bq
approved these changes
Mar 17, 2026
| */ | ||
|
|
||
| import { ConnectionPluginFactory } from "../../plugin_factory"; | ||
| import { PluginService } from "../../plugin_service"; |
Contributor
There was a problem hiding this comment.
Think we can remove this import
faviansamatha
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.