Skip to content

Mining: check for unknown origin as part of the valid pending transaction#1557

Open
bchamagne wants to merge 2 commits intoarchethic-foundation:developfrom
bchamagne:1539-unknown-origin
Open

Mining: check for unknown origin as part of the valid pending transaction#1557
bchamagne wants to merge 2 commits intoarchethic-foundation:developfrom
bchamagne:1539-unknown-origin

Conversation

@bchamagne
Copy link
Contributor

Description

Differentiate an invalid proof of work from an unknown origin.
Fixes #1539

Type of change

  • Improvment

How Has This Been Tested?

I modified the CLI to send invalid origin signature. Then I sent a transaction with the CLI
Capture d’écran 2024-08-26 à 16 50 51

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added mining Involve transaction validation and mining quality Improve code quality labels Aug 26, 2024
@bchamagne bchamagne marked this pull request as draft August 26, 2024 15:20
@bchamagne bchamagne force-pushed the 1539-unknown-origin branch from 81374ba to 6c1815c Compare August 27, 2024 12:30
@bchamagne bchamagne marked this pull request as ready for review August 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mining Involve transaction validation and mining quality Improve code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect handling of not found proof of work

2 participants