-
Notifications
You must be signed in to change notification settings - Fork 1k
RANGER-5433: update service-def json files to improve readability and consistent formatting #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… consistent formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the service definition JSON files for Apache Ranger to improve readability and maintain consistent formatting across all files. The changes consolidate multi-line JSON objects into single-line entries where appropriate, remove empty/unused sections, and standardize property ordering.
Key changes:
- Condensed multi-line JSON object definitions to single-line format for better readability
- Removed empty arrays and unused sections (e.g., empty
enums,contextEnrichers,policyConditions) - Standardized property ordering within resource and configuration objects
- Eliminated unnecessary whitespace and blank lines
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ranger-servicedef-yarn.json | Consolidated resources, accessTypes, configs, and enums into compact single-line format |
| ranger-servicedef-wasb.json | Reformatted resources, accessTypes, and configs; moved options field to top-level |
| ranger-servicedef-trino.json | Compressed resources, accessTypes, configs, dataMaskDef, and rowFilterDef definitions |
| ranger-servicedef-tag.json | Condensed resources, configs; removed empty enums section |
| ranger-servicedef-storm.json | Reformatted resources, accessTypes, and configs into compact format |
| ranger-servicedef-sqoop.json | Consolidated resources, accessTypes, configs; moved options to top-level |
| ranger-servicedef-solr.json | Compressed resources, accessTypes, configs, and policyConditions |
| ranger-servicedef-schema-registry.json | Reformatted all sections into single-line format; removed empty sections |
| ranger-servicedef-presto.json | Condensed resources, accessTypes, configs, dataMaskDef, and rowFilterDef |
| ranger-servicedef-ozone.json | Reformatted resources, accessTypes, configs, enums, and policyConditions |
| ranger-servicedef-nifi.json | Consolidated resources, accessTypes, configs, and enums; moved options to top |
| ranger-servicedef-nifi-registry.json | Similar reformatting as nifi.json with moved options |
| ranger-servicedef-nestedstructure.json | Reorganized field order and consolidated dataMaskDef/rowFilterDef sections |
| ranger-servicedef-kylin.json | Condensed all sections; moved options to top-level |
| ranger-servicedef-kudu.json | Reformatted resources, accessTypes, and configs |
| ranger-servicedef-knox.json | Consolidated resources, accessTypes, configs, and policyConditions |
| ranger-servicedef-kms.json | Compressed all sections; moved options to top |
| ranger-servicedef-kafka.json | Reformatted resources, accessTypes, configs, and policyConditions |
| ranger-servicedef-hive.json | Condensed resources, accessTypes, configs, dataMaskDef, and rowFilterDef |
| ranger-servicedef-hdfs.json | Reformatted resources, accessTypes, configs, and enums |
| ranger-servicedef-hbase.json | Consolidated resources, accessTypes, configs, and enums |
| ranger-servicedef-gds.json | Condensed resources; moved options to top-level |
| ranger-servicedef-elasticsearch.json | Reformatted all sections; moved options to top |
| ranger-servicedef-atlas.json | Comprehensive reformatting of resources, accessTypes, and configs; moved options to top |
| ranger-servicedef-abfs.json | Condensed resources, accessTypes, configs, and policyConditions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json
Outdated
Show resolved
Hide resolved
agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json
Outdated
Show resolved
Hide resolved
agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json
Outdated
Show resolved
Hide resolved
agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What changes were proposed in this pull request?
updated service-def json file to improve readability and keep consistent formatting across all files.
How was this patch tested?
Ranger admin successfully loaded service-defs on startup.