[lance] Do not replace oss scheme to s3 scheme #6764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
force-pushed
the
lance_path_fix
branch
2 times, most recently
from
17b9ae7 to
8f79101
Compare
Contributor
|
For open source lance sdk, can it works with OSS path? |
Contributor
Author
AKSK works well, but sts token does not work. Got your point, I need to think about a better way to deal this. |
XiaoHongbo-Hope
force-pushed
the
lance_path_fix
branch
2 times, most recently
from
2a753fa to
c39a713
Compare
fix merge issue
XiaoHongbo-Hope
force-pushed
the
lance_path_fix
branch
from
c39a713 to
9ac0bfe
Compare
|
+1 |
|
+1 |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We should not replace oss scheme to s3 scheme, and should keep the original oss config into storage options for lance.
Tests
lance_utils_test.pyLanceUtilsTestAPI and Format
Documentation