MINIFICPP-2708 Controller Service C API#2096
Open
martinzink wants to merge 6 commits intoapache:controller_c_api_requirementsfrom
Open
MINIFICPP-2708 Controller Service C API#2096martinzink wants to merge 6 commits intoapache:controller_c_api_requirementsfrom
martinzink wants to merge 6 commits intoapache:controller_c_api_requirementsfrom
Conversation
c4355e7 to
52b5626
Compare
There was a problem hiding this comment.
Pull request overview
This pull request implements a C API for Controller Services, extending the existing C API infrastructure (which previously only supported Processors) to include Controller Services. This aligns with the JIRA ticket MINIFICPP-2708 and allows Controller Services to be defined and used through the C interface.
Changes:
- Renamed
ControllerServiceApi/ControllerServiceApiDefinitiontypes toControllerServiceType/ControllerServiceTypeDefinitionfor better clarity - Moved
ControllerServiceMetadatafromcore::controllernamespace tocorenamespace for consistency - Added C API structures and functions for Controller Service definition, creation, and property access
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| minifi-api/include/minifi-c/minifi-c.h | Adds C API structures for controller services including MinifiControllerServiceContext, MinifiControllerServiceMetadata, MinifiControllerServiceCallbacks, and MinifiControllerServiceClassDefinition |
| libminifi/include/utils/CControllerService.h | New C++ wrapper class for controller services created through C API |
| libminifi/src/minifi-c.cpp | Implements C API functions for controller service operations including property access and service retrieval |
| minifi-api/include/minifi-cpp/core/ControllerServiceType.h | Renames ControllerServiceApi to ControllerServiceType for clarity |
| minifi-api/include/minifi-cpp/core/ControllerServiceTypeDefinition.h | Renames ControllerServiceApiDefinition to ControllerServiceTypeDefinition |
| minifi-api/common/include/minifi-cpp/core/ControllerServiceMetadata.h | Moves from controller namespace to core namespace |
| minifi-api/include/minifi-cpp/core/controller/ControllerServiceDescriptor.h | Adds overload for setSupportedProperties accepting Property span |
| libminifi/include/core/controller/ControllerService.h | Updates to use renamed types and implements new setSupportedProperties overload |
| extensions/*/*.cpp | Updates extension loaders to include new controller_services_count and controller_services_ptr fields |
| Extensions.md | Documents the new controller service fields in MinifiExtensionCreateInfo |
Comments suppressed due to low confidence (1)
minifi-api/common/include/minifi-cpp/core/ControllerServiceMetadata.h:2
- Inconsistent comment formatting: the asterisk on line 2 is not aligned with the others. It should be aligned with line 3's asterisk for consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0e54f0b to
d6bf004
Compare
b6d2def to
0a5d4de
Compare
8 tasks
256e577 to
0b72f10
Compare
17af633 to
20b3b0c
Compare
Member
Author
|
I think its better to also target #2105 I'll convert to draft while I sort out the PR dependencies. |
20b3b0c to
a9e20c0
Compare
b60ab71 to
b9cda13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built upon ongoing #2065 #2098 and #2105 PR-s
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.