chore(scripts): add compile scripts in ubuntu and macos#864
Open
SYaoJun wants to merge 1 commit intoapache:mainfrom
Open
chore(scripts): add compile scripts in ubuntu and macos#864SYaoJun wants to merge 1 commit intoapache:mainfrom
SYaoJun wants to merge 1 commit intoapache:mainfrom
Conversation
SYaoJun
force-pushed
the
0215_add_scripts
branch
from
384944a to
c430393
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
=========================================
Coverage 80.21% 80.21%
Complexity 615 615
=========================================
Files 93 93
Lines 10258 10255 -3
Branches 1050 1049 -1
=========================================
- Hits 8228 8226 -2
+ Misses 1790 1789 -1
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @SYaoJun , thank you for doing this. Imo, it would be better to introduce the role of the script synchronously in readme/docs |
SYaoJun
force-pushed
the
0215_add_scripts
branch
from
c430393 to
1857c2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Every time I compile the C++ project, I have to input a long list of compilation options, which is time-consuming and completely unnecessary.
Regarding the legacy issue #628:
On macOS, we must explicitly specify the Arrow include path; otherwise, the compilation will fail.
What changes are included in this PR?
Add two scripts on Ubuntu and MacOS
Are these changes tested?
yes
Are there any user-facing changes?
no