OpenAPI: Add SetPartitionStatisticsUpdate/RemovePartitionStatisticsUpdate to TableUpdate#14957
OpenAPI: Add SetPartitionStatisticsUpdate/RemovePartitionStatisticsUpdate to TableUpdate#14957nastra merged 1 commit intoapache:mainfrom
Conversation
open-api/rest-catalog-open-api.yaml
Outdated
| - $ref: '#/components/schemas/SetPropertiesUpdate' | ||
| - $ref: '#/components/schemas/RemovePropertiesUpdate' | ||
| - $ref: '#/components/schemas/AddViewVersionUpdate' | ||
| - $ref: '#/components/schemas/SetCurrentViewVersionUpdate' |
There was a problem hiding this comment.
These two entries already exist in ViewUpdate. Why should we add them to TableUpdate?
There was a problem hiding this comment.
Thanks for the catch, they shouldn't be copied over.
| - $ref: '#/components/schemas/SetStatisticsUpdate' | ||
| - $ref: '#/components/schemas/RemoveStatisticsUpdate' | ||
| - $ref: '#/components/schemas/SetPartitionStatisticsUpdate' | ||
| - $ref: '#/components/schemas/RemovePartitionStatisticsUpdate' |
feefs
left a comment
There was a problem hiding this comment.
Addressed comments.
8e1b014 to
ef3a35f
Compare
|
@ebyhr friendly bump, I've rebased on top of the latest changes. |
ebyhr
left a comment
There was a problem hiding this comment.
Looks good to me.
@Fokko @singhpk234 @huaxingao Could you review this PR when you have time?
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, i think its a miss mostly since java client supports it in ser-de, vote should not be required.
Lets see what others have to say !
|
@ebyhr @singhpk234 @huaxingao @Fokko another friendly bump, are the current approvals sufficient for merging? |
9310150 to
9aae4c3
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
I think this can be merged without a vote. |
|
also cc @nastra |
Yes I agree, I don't think we need a vote here because we're just adding something that was initially missed to be added |
I think this should be a follow-up to #9690 (
set-partition-statisticsandremove-partition-statisticswere added toBaseUpdate'sdiscriminator:YAML sequence but notTableUpdate'sanyOf:YAML sequence) and #9240 (original refactor fromenum:todiscriminator:).Without this, the JSON Schema I'm generating for my validator is incorrectly rejecting
CommitTableRequestpayloads with TableUpdate schema objects such asset-partition-statistics.Ran my changes through:
and everything passes.