feat: Impl Transform::ToHumanString #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
reviewed
Jan 12, 2026
wgtmac
requested changes
Jan 13, 2026
| Result<std::unique_ptr<UnboundPredicate>> ProjectStrict( | ||
| std::string_view name, const std::shared_ptr<BoundPredicate>& predicate); | ||
|
|
||
| /// \brief Returns a human-readable String representation of a transformed value. |
Member
There was a problem hiding this comment.
Suggested change
| /// \brief Returns a human-readable String representation of a transformed value. | |
| /// \brief Returns a human-readable string representation of a transformed value. |
| /// \brief Returns a human-readable String representation of a transformed value. | ||
| /// | ||
| /// \param value The literal value to be transformed. | ||
| /// \return A human-readable String representation of the value |
Member
There was a problem hiding this comment.
Suggested change
| /// \return A human-readable String representation of the value | |
| /// \return A human-readable string representation of the value |
| } | ||
|
|
||
| Result<std::string> Transform::ToHumanString(const Literal& value) { | ||
| if (value.IsNull()) { |
Member
There was a problem hiding this comment.
Let's return error when IsAboveMax() or IsBelowMin() is true.
|
|
||
| switch (transform_type_) { | ||
| case TransformType::kYear: | ||
| return TransformUtil::HumanYear(std::get<int32_t>(value.value())); |
Member
There was a problem hiding this comment.
We might need to check the literal type before calling std::get on the variant value to avoid exception.
| return TransformUtil::HumanDay(std::get<int32_t>(value.value())); | ||
| case TransformType::kHour: | ||
| return TransformUtil::HumanHour(std::get<int32_t>(value.value())); | ||
| default: { |
Member
There was a problem hiding this comment.
Can we remove this default and add all other branches explicitly to avoid forgetting to update here in the future once we add a new transform type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.