IsBoundVisitor mixed bound/unbound predicate should error #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Jan 12, 2026
src/iceberg/expression/binder.cc
Outdated
| } | ||
|
|
||
| Result<bool> IsBoundVisitor::AlwaysTrue() { return true; } | ||
| Result<std::optional<bool>> IsBoundVisitor::AlwaysTrue() { return std::nullopt; } |
Member
There was a problem hiding this comment.
I think the Java impl is overly complicated to return null by default and then a lot of places should handle null with different meanings.
Member
There was a problem hiding this comment.
What about letting each visitors to handle this instead of complicating the return type?
zhjwpku
force-pushed
the
fix_is_bound_expression
branch
from
1ba9c7d to
366c586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.