feat: add restcatalog authentication api #479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
reviewed
Jan 13, 2026
| /// \param properties Configuration properties. | ||
| /// \return A session for initialization, or the catalog session by default. | ||
| virtual std::shared_ptr<AuthSession> InitSession( | ||
| HttpClient* init_client, |
Contributor
There was a problem hiding this comment.
why use raw pointer？🤔 use std::shared_ptr instead?
Contributor
Author
There was a problem hiding this comment.
AuthManager simply borrows the HTTP client owned by the catalog, it isn’t supposed to manage that client’s lifetime, so here use raw pointer.
wgtmac
reviewed
Jan 14, 2026
Comment on lines
+18
to
+23
| set(ICEBERG_REST_AUTH_SOURCES auth_session.cc auth_manager.cc auth_managers.cc) | ||
|
|
||
| # Expose sources to parent scope for inclusion in iceberg_rest library | ||
| set(ICEBERG_REST_AUTH_SOURCES | ||
| ${ICEBERG_REST_AUTH_SOURCES} | ||
| PARENT_SCOPE) |
Member
There was a problem hiding this comment.
Suggested change
| set(ICEBERG_REST_AUTH_SOURCES auth_session.cc auth_manager.cc auth_managers.cc) | |
| # Expose sources to parent scope for inclusion in iceberg_rest library | |
| set(ICEBERG_REST_AUTH_SOURCES | |
| ${ICEBERG_REST_AUTH_SOURCES} | |
| PARENT_SCOPE) | |
| iceberg_install_all_headers(iceberg/catalog/rest/auth) |
The current pattern is inconsistent with other CMake config. We should only install headers for this subdirectory here.
Comment on lines
+32
to
+36
| # Add auth sources with proper path prefix | ||
| foreach(AUTH_SOURCE ${ICEBERG_REST_AUTH_SOURCES}) | ||
| list(APPEND ICEBERG_REST_SOURCES "auth/${AUTH_SOURCE}") | ||
| endforeach() | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| # Add auth sources with proper path prefix | |
| foreach(AUTH_SOURCE ${ICEBERG_REST_AUTH_SOURCES}) | |
| list(APPEND ICEBERG_REST_SOURCES "auth/${AUTH_SOURCE}") | |
| endforeach() |
Let's remove these lines by directly adding those files in the above set(ICEBERG_REST_SOURCES).
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # Include auth subdirectory |
Member
There was a problem hiding this comment.
Suggested change
| # Include auth subdirectory |
This comment is unnecessary.
|
|
||
| } // namespace iceberg::rest | ||
|
|
||
| namespace iceberg::rest::auth { |
Member
There was a problem hiding this comment.
Do we really need the extra auth namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add restcatalog authentication api