[GOBBLIN-2243]Add Fallback dir for Jar caching#4160
Merged
Blazer-007 merged 5 commits intoapache:masterfrom Dec 18, 2025
Merged
[GOBBLIN-2243]Add Fallback dir for Jar caching#4160Blazer-007 merged 5 commits intoapache:masterfrom
Blazer-007 merged 5 commits intoapache:masterfrom
Conversation
Blazer-007
reviewed
Dec 16, 2025
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
Outdated
Show resolved
Hide resolved
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/GobblinYarnAppLauncherTest.java
Outdated
Show resolved
Hide resolved
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
Outdated
Show resolved
Hide resolved
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnConfigurationKeys.java
Outdated
Show resolved
Hide resolved
Comment on lines
1078
to
1079
| return config.withValue(GobblinYarnConfigurationKeys.JAR_CACHE_DIR, | ||
| ConfigValueFactory.fromAnyRef(fullPath)); |
Contributor
There was a problem hiding this comment.
computing JAR_CACHE_DIR from filesystem state at config load time makes it hard to debug. We can introduce a JarCachePathResolver instead that computes the resolved cache dir, when needed.
If that's too big a change, for now, let's check that JAR_CACHE_DIR is not already explicitly configured(if it is, use it as is) to avoid overriding an existing config.
Contributor
Author
There was a problem hiding this comment.
makes sense, removed logic from constructor , made JarCachePathResolver
a3a1a43 to
098498a
Compare
098498a to
e83b2b4
Compare
Blazer-007
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Add Jar Cache Directory Validation with Fallback
Summary
Implements validation for jar cache directories with automatic fallback handling in GobblinYarnAppLauncher.
Changes
Added addJarCachingConfig() method: Validates JAR_CACHE_DIR exists on filesystem, falls back to FALLBACK_JAR_CACHE_DIR if not found, or disables jar caching if neither exists
Tests
Added unit tests
Commits