Check if function type is nil before attempting to register the function#325
Open
pocockn wants to merge 1 commit intoapache:masterfrom
Open
Check if function type is nil before attempting to register the function#325pocockn wants to merge 1 commit intoapache:masterfrom
pocockn wants to merge 1 commit intoapache:masterfrom
Conversation
phatjam98
approved these changes
Mar 7, 2023
phatjam98
left a comment
phatjam98
left a comment
There was a problem hiding this comment.
This looks great. I am also just getting started as a contributor to Statefun. Is there a JIRA ticket for this one?
Author
No JIRA ticket, would be happy to make one. Do you have a link to the board? |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't pass a function type to the builders
WithSpecmethod it doesn't error within the Go SDK but the function isn't registered within Flink and doesn't run correctly.You can see the error within the Flink UI but the Go SDK just logs
"registering Stateful Function nil"And then carries on as usual
I've added a check to ensure that a function type is passed down into the builders
WithSpecmethod