FINERACT-2413: Schedule handling after re-amortization default behavior #5251
+473
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzeynalov
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
2 times, most recently
from
e568c0e to
b5c484f
Compare
Aman-Mittal
reviewed
Dec 27, 2025
|
|
||
| private boolean shouldUseEmiCalculation(TransactionCtx transactionCtx, LocalDate transactionDate) { | ||
| if (transactionCtx instanceof ProgressiveTransactionCtx progressiveTransactionCtx) { | ||
| boolean hasActiveReAmortization = progressiveTransactionCtx.getAlreadyProcessedTransactions().stream() |
Contributor
There was a problem hiding this comment.
Can you explain the removal of this logic? hasActiveReAmortization. Even through tests wise code is ok.
Interested in usecase related point of view. why re amortize logic is being removed here/
Contributor
There was a problem hiding this comment.
It was removed, because now EmiCalculator is supporting reamortization handling.
To be honest i think the reage part should be also removed. We should only not use emicalculator if current date is after maturity date. @oleksii-novikov-onix FYI
ruzeynalov
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
b5c484f to
362ce49
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
d8a69c2 to
8e70cf5
Compare
…n default behavior
oleksii-novikov-onix
force-pushed
the
FINERACT-2413/schedule-handling-after-re-amortization-default-behaviour
branch
from
8e70cf5 to
f76fdcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.