perf: Improve string to int perf #3017
Open
+52
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Initial benchmarks showed improvement to match with Spark's performance. I will continue to profile the code to see if we can squeeze in additional optimization |
coderfender
changed the title
coderfender
commented
Jan 3, 2026
| cast_array.append_value(cast_value); | ||
| } else { | ||
| cast_array.append_null() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
made null check conditional to remove unwanted branching
| if len == 1 { | ||
| return none_or_err(eval_mode, type_name, str); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Same (removed unwanted If branching)
| let mut parse_sign_and_digits = true; | ||
|
|
||
| for (i, ch) in trimmed_str.char_indices() { | ||
| for &ch in &trimmed_bytes[idx..] { |
Contributor
Author
There was a problem hiding this comment.
Cleaner and faster approach to access the chars directly
Contributor
Author
|
Results : |
Contributor
Author
|
Proceeding with some rather unsafe options to see if we can squeeze in further optimizations |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
============================================
+ Coverage 56.12% 59.56% +3.43%
- Complexity 976 1379 +403
============================================
Files 119 167 +48
Lines 11743 15496 +3753
Branches 2251 2569 +318
============================================
+ Hits 6591 9230 +2639
- Misses 4012 4968 +956
- Partials 1140 1298 +158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2981
Rationale for this change
What changes are included in this PR?
How are these changes tested?