chore: Refactor CometScanRule to improve scan selection and fallback logic
#2978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
============================================
+ Coverage 56.12% 59.47% +3.34%
- Complexity 976 1381 +405
============================================
Files 119 167 +48
Lines 11743 15521 +3778
Branches 2251 2571 +320
============================================
+ Hits 6591 9231 +2640
- Misses 4012 4993 +981
- Partials 1140 1297 +157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
CometScanRule to improve scan selection and fallback logicCometScanRule to improve scan selection and fallback logic [WIP]
andygrove
changed the title
CometScanRule to improve scan selection and fallback logic [WIP]CometScanRule to improve scan selection and fallback logic
andygrove
changed the title
CometScanRule to improve scan selection and fallback logicCometScanRule to improve scan selection and fallback logic [WIP]
andygrove
changed the title
CometScanRule to improve scan selection and fallback logic [WIP]CometScanRule to improve scan selection and fallback logic
parthchandra
reviewed
Jan 5, 2026
Comment on lines
159
to
161
| withInfo( | ||
| scanExec, | ||
| "Full native scan disabled because nested types for default values are not supported") |
Contributor
There was a problem hiding this comment.
Perhaps should be - "Full native scan disabled because default values for nested types are not supported"
| return scanExec | ||
| } | ||
|
|
||
| // TODO is this restriction valid for all native scan types? |
Contributor
There was a problem hiding this comment.
Are default values for primitive types supported by native_datafusion?
parthchandra
approved these changes
Jan 6, 2026
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
lgtm. Minor comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Refactoring to simplify scan selection and fallback logic
What changes are included in this PR?
No functional changes. Just refactoring.
How are these changes tested?
Existing tests.