-
Notifications
You must be signed in to change notification settings - Fork 119
Allow copy of templates from secondary storages of same or other zone when adding a new secondary storage #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
…y added secondary storage
| | | when adding a new Secondary Storage, instead of downloading them from the source URL. | | | ||
| +----------------------------------------------+-------------------------------------------------------------------------------------------------------------+-----------+ | ||
|
|
||
| This setting is enabled by default and can be configured globally or at zone level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when creating a zone it is enabled by default, so preventing it will be hard right? A race against the machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point Daan. When creating a zone, it uses the global setting (not zone level). I also want to keep the default value to false to keep it backward compatible. But the first PR is already merged apache/cloudstack#10363, I can do that change in my subsequent PR apache/cloudstack#12296
One another point to note, if the setting is enabled, first it attempts to copy from secondary storage, if it fails then it fall back to old behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not mind enabling by default, just something to be aware of (and maybe document here). If useful to alternate we may wat to add a switch to the zone wizard (i.e set it before enabling the zone)
|
@blueorangutan docbuild |
|
@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/611. (QA-JID 470) |
abh1sar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
some nitpicks regarding capitalisations.
|
thank you @abh1sar I've addressed all of them |
This document is in relation to the PRs apache/cloudstack#10363 and apache/cloudstack#12296
📚 Documentation preview 📚: https://cloudstack-documentation--611.org.readthedocs.build/en/611/