Skip to content

Conversation

@Mandukhai-Alimaa
Copy link
Contributor

@Mandukhai-Alimaa Mandukhai-Alimaa commented Jan 13, 2026

Move the SetSqlState call inside the null check to only execute when sqlstate is valid.

Closes #3878

@github-actions github-actions bot added this to the ADBC Libraries 23 milestone Jan 13, 2026
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing CI in #3892

@lidavidm
Copy link
Member

Can you rebase?

Copy link

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to create a test for this?

@Mandukhai-Alimaa
Copy link
Contributor Author

I will create some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adbc_postgresql: core dump if server terminates the connection

3 participants