removes mutable list constant from DefaultKeySizeConstraint#6163
Merged
keith-turner merged 5 commits intoapache:2.1from Mar 4, 2026
Merged
removes mutable list constant from DefaultKeySizeConstraint#6163keith-turner merged 5 commits intoapache:2.1from
keith-turner merged 5 commits intoapache:2.1from
Conversation
Contributor
Author
|
Saw an odd test failure on #6162, not sure how it happened but suspect another unit test modified the mutable list constant that was in DefaultKeySizeConstraint https://github.com/apache/accumulo/actions/runs/22591069279/job/65449119120 |
ctubbsii
reviewed
Mar 2, 2026
| @Override | ||
| public List<Short> check(Environment env, Mutation mutation) { | ||
|
|
||
| // fast size check | ||
| if (mutation.numBytes() < maxSize) { | ||
| return NO_VIOLATIONS; | ||
| return null; |
Member
There was a problem hiding this comment.
This is a change in behavior, which I think we should probably try to avoid, unless... is null documented as a special case?
Alternatively, could replace this with an unmodifiable or immutable list.
Contributor
Author
There was a problem hiding this comment.
Yeah, the javadoc for the super class says to return null when there are no violations.
ctubbsii
previously approved these changes
Mar 3, 2026
ctubbsii
dismissed
their stale review
This needs to be based on 2.1 to fix it there.
ddanielr
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.