Have amuse.lab raise original ImportError if code is missing#1228
Open
LourensVeen wants to merge 1 commit intoamusecode:mainfrom
Open
Have amuse.lab raise original ImportError if code is missing#1228LourensVeen wants to merge 1 commit intoamusecode:mainfrom
LourensVeen wants to merge 1 commit intoamusecode:mainfrom
Conversation
rieder
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
amuse.labto try to import the optional codes it likes to import, catch and store the exception it gets from theamuse.communityforwarders if it doesn't work, and then raise that exception if the user tries to use the imported class or function.This way, the user can still do
from amuse.lab import *(even if that's bad practice, it's what we've got), and we only have one place where import error messages are generated.Fixes #1192.