Replace examples with those from the second edition of the AMUSE book#1227
Open
rieder wants to merge 7 commits intoamusecode:mainfrom
Open
Replace examples with those from the second edition of the AMUSE book#1227rieder wants to merge 7 commits intoamusecode:mainfrom
rieder wants to merge 7 commits intoamusecode:mainfrom
Conversation
Member
Author
|
To be done:
|
Member
Author
|
If we do want to keep (some of) the old examples around, they should be in some directory that makes it clear that these are archived, and not updated. If they are still useful, they should be moved to the new structure. |
Member
|
I don't see how the tests would depend on the examples, but I'll go and do a local build and run them all to check. I think pip packages, the PDF, and more examples should be separate Issues, so if it doesn't break the tests then I'll merge this, even if it isn't perfect I doubt it'll make things worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing examples are outdated, in some cases not working and often duplicated by others.
This replaces all examples from the "textbook", "syllabus" and "simple" directories with the complete set from the textbook (second edition).