fix(exposure): send user properties on exposure events#74
Open
FabricioFFC wants to merge 1 commit intoamplitude:mainfrom
Open
fix(exposure): send user properties on exposure events#74FabricioFFC wants to merge 1 commit intoamplitude:mainfrom
FabricioFFC wants to merge 1 commit intoamplitude:mainfrom
Conversation
Update
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forwards
user_propertiesfromExperimentUserto exposure events by spreading them into the$setblock alongside the existing experiment-related properties. This ensures that custom user properties set on the user object are included when exposure events are tracked.Fixes: #72
Note: This change could also be applied to
AmplitudeAssignmentService, but since it's being deprecated, I chose to leave it unchanged. Please let me know if you'd prefer it to be updated as well.Checklist