Open
Conversation
When resolving relative paths (e.g., for transclusion), handle the case where intermediate path components are git "portable symlinks" - small text files containing the target path rather than actual filesystem symlinks. This enables proper path resolution in repositories that use git's core.symlinks=false setting. The implementation: - Wraps normal path resolution in try-catch - On failure, falls back to symlink-aware traversal - Detects git symlinks by checking file size (<1KB) and contents - Follows symlink targets during directory traversal
Owner
|
Can you describe your use case a bit more? You're right that git will store a symlink as a text file, but after checkout that should turn back into a symlink in the worktree that would, in theory, already be resolvable with current mechanisms. What app on your phone is allowing you to check out a git repository but is leaving symlinks in git's internal representation? |
Author
|
I am using GitSync from the Play Store |
Owner
|
I don't think it makes a lot of sense to make Orgro understand something git-specific. It sounds like GitSync should be making actual symlinks. Have you tried discussing it with them? It looks like they accept discussions and bug reports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transclusion wasn't working for paths like [[file:img/achilles.jpg]] where img is a symlink managed by GitHub (stored as a text file containing the target path).
This adds a fallback in resolveRelative that walks path components individually and follows these portable symlink files when encountered.