-
Notifications
You must be signed in to change notification settings - Fork 4
Lesson Five #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
halidickson
wants to merge
4
commits into
amaclean2:lesson-five
Choose a base branch
from
halidickson:lesson-five
base: lesson-five
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lesson Five #13
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,33 +17,50 @@ | |
| # only if the length of the list is less than 5. | ||
| def addToList(element) : | ||
| # your code here | ||
|
|
||
| if len(myList) <= 5: | ||
| myList.append(element) | ||
| return myList | ||
|
|
||
| # Complete a function that removes the last element from the list | ||
| # 'myList', and returns it unless there is one left, then leave it. | ||
| def removeFromList() : | ||
| # your code here | ||
|
|
||
|
|
||
| if len(myList) > 1: | ||
| myList.pop() | ||
| return myList | ||
| else: | ||
| return myList | ||
|
|
||
| # Complete a function that returns the index of 'element'. | ||
| # If the list doesn't contain the element then return -1. | ||
| def getIndex(element) : | ||
| # your code here | ||
|
|
||
|
|
||
| for item in myList: | ||
| if item != element: | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is going to return -1 a lot. It's kind of like the same thing you fixed in the last exercise |
||
| return -1 | ||
| elif item == element: | ||
| return myList.index(element) | ||
|
|
||
| # Complete a function that calls getElement() and prints the value | ||
| # it returns. | ||
| # it returns. | ||
| # Should getElement() be getIndex() from above? I'm going to assume that. | ||
| def printIndex(element) : | ||
| # your code here | ||
|
|
||
| for item in myList: | ||
| if item == element: | ||
| getIndex(element) | ||
| print (myList.index(element)) | ||
|
|
||
| # Complete a function that removes the element 'element' from the | ||
| # list and returns it. If the element doesn't exist, then return -1. | ||
| def removeElement(element) : | ||
| # your code here | ||
|
|
||
| for item in myList: | ||
| if item == element: | ||
| getIndex(element) | ||
| return myList.pop(myList.index(element)) | ||
|
|
||
| return -1 | ||
|
|
||
| #-----# | ||
|
|
||
|
|
@@ -84,7 +101,7 @@ def removeElement(element) : | |
| printIndex(13) | ||
|
|
||
| print("6: ") | ||
| printIndex(13) | ||
| printIndex(6) | ||
|
|
||
| elem = removeElement(13) | ||
| print("removed 13: ", elem) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one just needs to return
myList.pop()