fix: allow duplicate downloads by unique filenames#121
Open
sinkaroid wants to merge 1 commit intoalphasp:masterfrom
Open
fix: allow duplicate downloads by unique filenames#121sinkaroid wants to merge 1 commit intoalphasp:masterfrom
sinkaroid wants to merge 1 commit intoalphasp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
getUniqueFilePath()to append_1,_2, ... until a free filename is found.Real use case
I love the simplicity for PxViewr, I hope this project still maintained..
So.. I often re-download older images saved long ago (e.g., last year, last month or even last week). I expected the app to overwrite or at least surface a new file, but because the same path is reused, Gallery shows no visible changes.
This change ensures a new filename for duplicates, so re-downloading old images actually produces a visible new file.