-
-
Notifications
You must be signed in to change notification settings - Fork 43
chore(deps): update postgres docker tag to v18 #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dependency Reviewβ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
=======================================
Coverage 40.21% 40.21%
=======================================
Files 206 206
Lines 15772 15772
Branches 1956 1956
=======================================
Hits 6342 6342
Misses 9430 9430 β View full report in Codecov by Sentry. |
| datasource | package | from | to | | ---------- | -------- | ---- | -- | | docker | postgres | 17 | 18 |
c894940 to
a29cd38
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
| container_name: tux-postgres | ||
| hostname: tux-postgres | ||
| image: postgres:17-alpine@sha256:ff4ccc02b97e0ebb6b328ef9ff92522f95586f83be6801896b615088defc8ad2 | ||
| image: postgres:18-alpine@sha256:b40d931bd0e7ce6eecc59a5a6ac3b3c04a01e559750e73e7086b6dbd7f8bf545 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The PostgreSQL major version upgrade from 17 to 18 lacks a data migration strategy, which will cause startup failures for existing deployments with persistent data.
Severity: HIGH
Suggested Fix
A migration path for existing data must be provided. This can be achieved by adding an automated migration script that uses pg_upgrade or a dump/restore process. Alternatively, provide a detailed, documented manual migration procedure for users to follow. Reverting to PostgreSQL 17 is also an option until a proper migration strategy is implemented.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: compose.yaml#L28
Potential issue: The pull request upgrades the PostgreSQL image from version 17 to 18 in
`compose.yaml`. Major PostgreSQL versions have incompatible on-disk data formats. For
existing deployments using the persistent Docker volume `tux_postgres_data`, the new
PostgreSQL 18 container will attempt to start with a PostgreSQL 17 data directory. This
will cause an immediate startup failure because the data format is incompatible. Since
the application container depends on the database, it will also fail to start, leading
to a service outage for any existing installation.
Did we get this right? π / π to inform future reviews.
This PR contains the following updates:
17-alpineβ18-alpineConfiguration
π Schedule: Branch creation - "before 4am on Monday" in timezone America/New_York, Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled because a matching PR was automerged previously.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.