Fix dollar sign in TeaserV1 action title#9
Open
samuelgomezvaltech wants to merge 1 commit intoadobe:masterfrom
Open
Fix dollar sign in TeaserV1 action title#9samuelgomezvaltech wants to merge 1 commit intoadobe:masterfrom
samuelgomezvaltech wants to merge 1 commit intoadobe:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage ? 98.21%
=========================================
Files ? 33
Lines ? 393
Branches ? 86
=========================================
Hits ? 386
Misses ? 7
Partials ? 0 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Removes output of dollar sign before action title on TeaserV1
Description
Cleanup dollar sign and create corresponding unit test
Related Issue
#6
Motivation and Context
Teaser action links output a title that does not correspond to the specification; prepending a dollar sign that, yeah, is a typo.
How Has This Been Tested?
Extended TeaserV1.tests.tsx to check for the HTML from .cmp-teaser__action-container
Ran
npm run testwith the original code and there is a FAIL on TeaserV1.test.tsxThen ran again
npm run testwith the changed code in TeaserV1.tsx and all tests are green.Types of changes
Checklist: