feat: Extract ROOT histogram profiling to Plugin; Add 2D resolution profiles to Examples#5196
Draft
andiwand wants to merge 8 commits intoacts-project:mainfrom
Draft
feat: Extract ROOT histogram profiling to Plugin; Add 2D resolution profiles to Examples#5196andiwand wants to merge 8 commits intoacts-project:mainfrom
andiwand wants to merge 8 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Examples
Contributor
📊: Physics performance monitoring for 094ddc3Full contents |
github-actions
bot
added
Infrastructure
|
benjaminhuth
reviewed
Mar 6, 2026
benjaminhuth
reviewed
Mar 6, 2026
benjaminhuth
previously approved these changes
Mar 6, 2026
Member
benjaminhuth
left a comment
benjaminhuth
left a comment
There was a problem hiding this comment.
Looks good to me, feel free to resolve the comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #5182 we can have 2D resolution plots. For now I added them to
ResPlotToolusing(eta, phi)and(eta, pt). This also extracts the ROOT fit into the plugin and places it inActsPlugins/Root/HistogramConverter.hpp.Also
HistogramConverter--- END COMMIT MESSAGE ---