Add ActiveHash::Relation#or to support OR-like queries#343
Open
opsys-saito wants to merge 1 commit intoactive-hash:masterfrom
Open
Add ActiveHash::Relation#or to support OR-like queries#343opsys-saito wants to merge 1 commit intoactive-hash:masterfrom
opsys-saito wants to merge 1 commit intoactive-hash:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
ActiveHash::Relation#or, allowing OR-like queries similar to ActiveRecord:The implementation returns a new relation representing the union of both result sets, deduplicated by
id.Behavior
idArgumentErrorwhen combining relations from different modelsImplementation Notes
Since ActiveHash operates entirely in memory, this implementation performs a union of the evaluated result sets rather than merging condition trees.
The returned value remains an
ActiveHash::Relation, preserving chainability and compatibility with existing APIs.Tests
Added specs covering: