Adds builder presubmit

[christianhelp]

Why

Until we have a CI/CD pipeline through CF or however this is hosted, we need to ensure our builds are good and consistent

What

• Combines presubmits into one yml,
• bumps node version, setup-node, and checkout
• renames Error.tsx to error.tsx due to a casing issue where the change was not picked up by git.

[coderabbitai]

📝 Walkthrough

Walkthrough

Consolidates GitHub Actions presubmit workflows by replacing a standalone prettier workflow with a combined presubmits workflow that includes both format-check and build jobs. Updates a route file's import path to reference ErrorFallback instead of Error component.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflows .github/workflows/presubmits.yml, .github/workflows/prettier.yml	Consolidates prettier-check job into new presubmits workflow alongside builder job; removes standalone prettier workflow. Both use Node.js 24 and pnpm.
Component Import Update apps/web/src/routes/__root.tsx	Updates import path from @/components/shared/Error to @/components/shared/ErrorFallback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A workflow takes shape, two jobs now as one,
Prettier joins builder where checks get done,
Imports renamed with care and grace,
ErrorFallback finds its rightful place! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Adds builder presubmit' accurately reflects the main change: adding a builder job to the presubmit workflow. However, it omits the secondary change of bumping the Node version to LTS, which the commit message and PR description explicitly mention.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch adds-builder-presubmit

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

.github/workflows/presubmits.yml (1)

20-22: Consider using pnpm/action-setup instead of global npm install.

This is the recommended way to install pnpm in GitHub Actions. It's faster, supports version pinning, and integrates with actions/setup-node@v4's dependency caching (cache: 'pnpm'), which would significantly speed up both jobs.

Example refactor (for each job)

+            - name: Install pnpm
+              uses: pnpm/action-setup@v4
+              with:
+                  version: 9
+
             - name: Set up Node.js
-              uses: actions/setup-node@v2
+              uses: actions/setup-node@v4
               with:
-                  node-version: "24"
-
-            - name: Install pnpm
-              run: |
-                  npm install -g pnpm
+                  node-version: "22"
+                  cache: "pnpm"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/presubmits.yml around lines 20 - 22, The workflow step
currently named "Install pnpm" uses a global npm install (npm install -g pnpm);
replace that step with the official pnpm/action-setup action to install a pinned
pnpm version and enable fast setup and caching with actions/setup-node@v4 (use
cache: 'pnpm' on setup-node). Update the step referenced as "Install pnpm" to
call pnpm/action-setup (specify a version input) and ensure the corresponding
actions/setup-node@v4 step includes cache: 'pnpm' so dependency caching works
correctly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/presubmits.yml:
- Around line 15-18: Update the GitHub Actions step that reads "Set up Node.js"
using actions/setup-node@v2 to a supported major (preferably
actions/setup-node@v6, or `@v4` if you prefer) in both occurrences (the "Set up
Node.js" steps and the prettier-check job's setup step), leaving node-version:
"24" unchanged; ensure the uses: value is replaced for each setup-node step so
both jobs use the new major version.

---

Duplicate comments:
In @.github/workflows/presubmits.yml:
- Around line 36-39: Update the Node setup in this job to use the newer action
and an LTS Node version: change the action reference from actions/setup-node@v2
to actions/setup-node@v3 (or latest major) and replace node-version: "24" with
an LTS spec such as "lts/*" (or the specific LTS number used elsewhere, e.g.,
"20") so the job uses the supported setup-node action and an LTS Node release.

---

Nitpick comments:
In @.github/workflows/presubmits.yml:
- Around line 20-22: The workflow step currently named "Install pnpm" uses a
global npm install (npm install -g pnpm); replace that step with the official
pnpm/action-setup action to install a pinned pnpm version and enable fast setup
and caching with actions/setup-node@v4 (use cache: 'pnpm' on setup-node). Update
the step referenced as "Install pnpm" to call pnpm/action-setup (specify a
version input) and ensure the corresponding actions/setup-node@v4 step includes
cache: 'pnpm' so dependency caching works correctly.