Skip to content

build(build): upgrade toolchain to go 1.25.7#2115

Open
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:use-go-1.25.7
Open

build(build): upgrade toolchain to go 1.25.7#2115
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:use-go-1.25.7

Conversation

@gzliudan
Copy link
Collaborator

Proposed changes

upgrade toolchain to go 1.25.7

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings February 26, 2026 03:51
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Go toolchain from version 1.25.5 to 1.25.7. The change affects the build system configuration, updating the toolchain directive in go.mod and modifying the GO version variable in the Makefile.

Changes:

  • Updated toolchain directive in go.mod from go1.25.5 to go1.25.7
  • Changed GO variable in Makefile from version 1.25.1 to "latest"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Updated toolchain directive to go1.25.7 to specify the required Go toolchain version
Makefile Changed GO variable from specific version 1.25.1 to "latest"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


GOBIN = $(shell pwd)/build/bin
GO ?= 1.25.1
GO ?= latest
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GO variable is being changed from a specific version to "latest", but this variable doesn't appear to be used anywhere in the Makefile. If this variable is intended for future use or external consumption, consider whether "latest" is appropriate, as it introduces unpredictability. If the variable is unused, consider removing it entirely to reduce confusion.

Suggested change
GO ?= latest

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


GOBIN = $(shell pwd)/build/bin
GO ?= 1.25.1
GO ?= latest
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the GO variable from a specific version (1.25.1) to "latest" creates version inconsistency with the toolchain specification in go.mod (go1.25.7). This can lead to different build environments using different Go versions. Consider either:

  1. Setting this to match the toolchain version (e.g., GO ?= 1.25.7), or
  2. Removing this variable if the toolchain directive in go.mod is sufficient for version control.

Additionally, note that the toolchain version go1.25.7 specified in go.mod does not exist yet.

Suggested change
GO ?= latest

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants