build(build): upgrade toolchain to go 1.25.7#2115
build(build): upgrade toolchain to go 1.25.7#2115gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Go toolchain from version 1.25.5 to 1.25.7. The change affects the build system configuration, updating the toolchain directive in go.mod and modifying the GO version variable in the Makefile.
Changes:
- Updated toolchain directive in go.mod from go1.25.5 to go1.25.7
- Changed GO variable in Makefile from version 1.25.1 to "latest"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updated toolchain directive to go1.25.7 to specify the required Go toolchain version |
| Makefile | Changed GO variable from specific version 1.25.1 to "latest" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| GOBIN = $(shell pwd)/build/bin | ||
| GO ?= 1.25.1 | ||
| GO ?= latest |
There was a problem hiding this comment.
The GO variable is being changed from a specific version to "latest", but this variable doesn't appear to be used anywhere in the Makefile. If this variable is intended for future use or external consumption, consider whether "latest" is appropriate, as it introduces unpredictability. If the variable is unused, consider removing it entirely to reduce confusion.
| GO ?= latest |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| GOBIN = $(shell pwd)/build/bin | ||
| GO ?= 1.25.1 | ||
| GO ?= latest |
There was a problem hiding this comment.
Changing the GO variable from a specific version (1.25.1) to "latest" creates version inconsistency with the toolchain specification in go.mod (go1.25.7). This can lead to different build environments using different Go versions. Consider either:
- Setting this to match the toolchain version (e.g., GO ?= 1.25.7), or
- Removing this variable if the toolchain directive in go.mod is sufficient for version control.
Additionally, note that the toolchain version go1.25.7 specified in go.mod does not exist yet.
| GO ?= latest |
Proposed changes
upgrade toolchain to go 1.25.7
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that