fix(crypto): remove keccak_ziren.go#2113
fix(crypto): remove keccak_ziren.go#2113gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the Ziren zkvm implementation of Keccak256 hashing and its associated dependency. The dependency github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime was causing build failures with an invalid version reference containing a future date (2026), and since the ziren build tag is not actively used in the project, the entire Ziren-specific implementation can be safely removed.
Changes:
- Removed the
crypto/keccak_ziren.gofile which provided an alternative Keccak256 implementation for the ziren build tag - Removed the Ziren zkvm_runtime dependency from go.mod and go.sum
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crypto/keccak_ziren.go | Removed entire file containing Ziren zkvm-based Keccak256 implementation (build tag: ziren) |
| go.mod | Removed github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime dependency |
| go.sum | Removed checksums for the Ziren zkvm_runtime dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
The dependency
github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtimebreaks our tests now. Since we don't use build tagziren, so the filecrypto/keccak_ziren.gocan be removed from our code base safely.Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that