Skip to content

fix(crypto): remove keccak_ziren.go#2113

Open
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:remove-zkvm_runtime
Open

fix(crypto): remove keccak_ziren.go#2113
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:remove-zkvm_runtime

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Feb 26, 2026

Proposed changes

The dependency github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime breaks our tests now. Since we don't use build tag ziren, so the file crypto/keccak_ziren.go can be removed from our code base safely.

github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime: github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime@v0.0.0-20260124092617-829590d2c921: invalid version: unknown revision 829590d2c921

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • [X ] fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • [X ] External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings February 26, 2026 03:09
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Ziren zkvm implementation of Keccak256 hashing and its associated dependency. The dependency github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime was causing build failures with an invalid version reference containing a future date (2026), and since the ziren build tag is not actively used in the project, the entire Ziren-specific implementation can be safely removed.

Changes:

  • Removed the crypto/keccak_ziren.go file which provided an alternative Keccak256 implementation for the ziren build tag
  • Removed the Ziren zkvm_runtime dependency from go.mod and go.sum

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
crypto/keccak_ziren.go Removed entire file containing Ziren zkvm-based Keccak256 implementation (build tag: ziren)
go.mod Removed github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime dependency
go.sum Removed checksums for the Ziren zkvm_runtime dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants