-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Scripts: Do not add CDATA wrappers in admin #10666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Do not add CDATA wrappers in admin #10666
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Fix a regression from [61411] where CDATA wrappers were added to `SCRIPT` tags in WP Admin. Developed in #10666. Follow-up to [61411]. Props sabernhardt. See #64428, #59883. git-svn-id: https://develop.svn.wordpress.org/trunk@61414 602fd350-edb4-49c9-b593-d223f7449a82
|
Merged in r61414. |
Fix a regression from [61411] where CDATA wrappers were added to `SCRIPT` tags in WP Admin. Developed in WordPress/wordpress-develop#10666. Follow-up to [61411]. Props sabernhardt. See #64428, #59883. Built from https://develop.svn.wordpress.org/trunk@61414 git-svn-id: http://core.svn.wordpress.org/trunk@60726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix a regression from [61411] where CDATA wrappers were added to `SCRIPT` tags in WP Admin. Developed in WordPress/wordpress-develop#10666. Follow-up to [61411]. Props sabernhardt. See #64428, #59883. Built from https://develop.svn.wordpress.org/trunk@61414 git-svn-id: https://core.svn.wordpress.org/trunk@60726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fix a regression from [61411] where CDATA wrappers were added to `SCRIPT` tags in WP Admin. Developed in WordPress#10666. Follow-up to [61411]. Props sabernhardt. See #64428, #59883. git-svn-id: https://develop.svn.wordpress.org/trunk@61414 602fd350-edb4-49c9-b593-d223f7449a82
r61411 introduced a regression where CDATA wrappers would be added to WP Admin for themes without HTML5 script support.
See #10658 (comment) (thanks @sabernhardt).
Follow-up to r61411.
The CDATA wrappers are expected to be removed in Ticket 64442 / #10660, but this smaller change can be landed first.
Trac ticket: https://core.trac.wordpress.org/ticket/64428
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.