util : autohide window : fix memory leaks#405
Merged
trigg merged 1 commit intoWayfireWM:masterfrom Mar 11, 2026
Merged
Conversation
soreau
approved these changes
Mar 11, 2026
Member
soreau
left a comment
soreau
left a comment
There was a problem hiding this comment.
I must say, this is basically a model pull request, bravo. It fixes a problem and has a clear commit message and additional text answering questions and explaining answers before anyone has to ask.
The only thing I might do differently, is include the additional comments in the commit message of the patch commit message so that it shows up in git history, i.e. git log. You can use git commit --amend for this, which will bring up your default EDITOR (env var) to amend the commit message. After the additional comments are added and the file saved+editor closed, the top commit will be modified. You can then git push -f <remote> <branch> the result. Something like this pseudo commit message might work:
uti: autohide window: fix memory leaks
Additional comments here that will be retained in git history, rather than
only some text in a pull request on github.
Some signal handlers were not getting disconnected, which leaks memory when an autohide window is made and removed (so, effectively, on monitor disconnection and reconnection)
AKArien
force-pushed
the
autohide-window-leaks
branch
from
b16df33 to
2f9e2c3
Compare
trigg
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some signal handlers are not getting disconnected, which leaks memory when an autohide window is made and removed (so, effectively, on monitor disconnection and reconnection)