Skip to content

⚡ Optimize Spider-Man start script by replacing fixed sleeps with WinWaitActive #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ven0m0 merged 1 commit into from
Mar 1, 2026
Merged

⚡ Optimize Spider-Man start script by replacing fixed sleeps with WinWaitActive #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Other/start_Spider-Man.ahk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ SetTitleMatchMode("Fast")

; Spider-Man requires Enter key to dismiss splash screen
WinWait("ahk_exe Spider-Man.exe")
Sleep(500)
WinWaitActive("ahk_exe Spider-Man.exe")
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WinWaitActive("ahk_exe Spider-Man.exe") is called without a timeout and without handling TimeoutError, so the script can block indefinitely if the game never reaches an active window (crash, launcher focus, admin/UAC, etc.). Add a bounded timeout and fail fast with an actionable MsgBox + ExitApp(1) when it times out.

Copilot uses AI. Check for mistakes.
Comment on lines 19 to +20
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WinWait("ahk_exe Spider-Man.exe") immediately followed by WinWaitActive(...) is redundant because WinWaitActive already waits for the window to exist before waiting for activation. Consider collapsing to a single wait (and update the PR description which claims a single WinWaitActive call).

Copilot uses AI. Check for mistakes.
ControlSend("{Enter}", , "ahk_exe Spider-Man.exe")
Sleep(3500)
WinActivate("ahk_exe Spider-Man.exe")
ExitApp()
Loading