Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the AML investigation agent implementation by modularizing the agent creation, introducing a Langfuse-compatible task wrapper, and adding a dedicated CLI for batch case processing. The refactoring improves code organization and makes the agent more suitable for both interactive (ADK web) and batch evaluation workflows.
Changes:
- Extracted agent creation logic into a reusable factory function with comprehensive configuration options
- Added a Langfuse-compatible task wrapper for integration with evaluation harnesses
- Created a new CLI module for running batch case analyses with progress tracking and resume capability
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| implementations/aml_investigation/cli.py | New CLI for batch processing AML cases from JSONL with concurrency control and resume support |
| implementations/aml_investigation/agent.py | Simplified to serve as ADK web entrypoint, delegating to the new agent factory |
| implementations/aml_investigation/README.md | Updated documentation to reflect new CLI usage and file naming conventions |
| aieng-eval-agents/aieng/agent_evals/aml_investigation/task.py | New task wrapper implementing Langfuse experiment protocol for AML investigations |
| aieng-eval-agents/aieng/agent_evals/aml_investigation/agent.py | New agent factory with configurable parameters and built-in tracing support |
| aieng-eval-agents/aieng/agent_evals/aml_investigation/init.py | Updated exports to include new agent factory and task wrapper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor AML investigation agent: add task and agent modules, update README and CLI.
Clickup Ticket(s): N/A
Type of Change
Changes Made
agent.pymodule in packagetask.pycontaining langfuse-compatible task functionagent.pyinimplmentations/to serve as entrypoint foradk webTesting
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
N/A
Screenshots/Recordings
N/A
Related Issues
N/A
Deployment Notes
N/A
Checklist