Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors trigger types from the uipath-runtime package to the uipath-core package, establishing shared types across UiPath Python packages. The change updates the dependency on uipath-core to a development version (0.5.1.dev1000450222) from test PyPI that contains the newly moved trigger types.
Changes:
- Removed
src/uipath/runtime/resumable/trigger.pycontaining trigger type definitions - Updated all imports to use
from uipath.core.triggers importinstead of local imports - Updated dependency specification to pin to dev version from test PyPI
- Removed trigger type exports from
uipath-runtimepublic API
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated uipath-core dependency to version 0.5.1.dev1000450222 from test PyPI |
| tests/test_resumable.py | Changed imports to use uipath.core.triggers |
| tests/test_chat.py | Changed imports to use uipath.core.triggers |
| src/uipath/runtime/resumable/trigger.py | Deleted file - trigger types moved to uipath-core |
| src/uipath/runtime/resumable/runtime.py | Updated imports to use uipath.core.triggers |
| src/uipath/runtime/resumable/protocols.py | Updated imports to use uipath.core.triggers |
| src/uipath/runtime/resumable/init.py | Removed trigger type exports from module |
| src/uipath/runtime/result.py | Updated imports to use uipath.core.triggers |
| src/uipath/runtime/debug/runtime.py | Updated imports to use uipath.core.triggers |
| src/uipath/runtime/chat/runtime.py | Updated imports to use uipath.core.triggers |
| src/uipath/runtime/chat/protocol.py | Updated imports to use uipath.core.triggers |
| src/uipath/runtime/init.py | Removed trigger type exports from public API |
| pyproject.toml | Pinned uipath-core to dev version and configured test PyPI source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyproject.toml
Outdated
| requires-python = ">=3.11" | ||
| dependencies = [ | ||
| "uipath-core>=0.5.0, <0.6.0", | ||
| "uipath-core==0.5.1.dev1000450222", |
There was a problem hiding this comment.
The dependency is pinned to a specific dev version from test PyPI. This is appropriate for WIP/testing but should not be merged to production. Before merging, this should be updated to use a stable version range (e.g., ">=0.5.1,<0.6.0") from the production PyPI index.
| "uipath-core==0.5.1.dev1000450222", | |
| "uipath-core>=0.5.1,<0.6.0", |
| __all__ = [ | ||
| "UiPathResumableStorageProtocol", | ||
| "UiPathResumeTriggerCreatorProtocol", | ||
| "UiPathResumeTriggerReaderProtocol", | ||
| "UiPathResumeTriggerProtocol", | ||
| "UiPathResumeTrigger", | ||
| "UiPathResumeTriggerType", | ||
| "UiPathApiTrigger", | ||
| ] |
There was a problem hiding this comment.
This introduces a breaking API change. The types UiPathResumeTrigger, UiPathResumeTriggerType, UiPathApiTrigger, and UiPathResumeTriggerName were previously exported from uipath.runtime and are now removed. Users importing these types from uipath.runtime will experience import errors. Consider either: (1) re-exporting these types from uipath.runtime for backward compatibility, or (2) documenting this as a breaking change with migration instructions in the release notes.
|
|
||
| [tool.uv.sources] | ||
| uipath-core = { index = "testpypi" } |
There was a problem hiding this comment.
Configuring uipath-core to use test PyPI is appropriate for WIP/testing but should be removed before merging to production. Production releases should use packages from the official PyPI index.
| [tool.uv.sources] | |
| uipath-core = { index = "testpypi" } |
ToDo:
Development Package