fix: isolate env variables between cli server command runs#1366
Merged
cristipufu merged 1 commit intomainfrom Feb 24, 2026
Merged
fix: isolate env variables between cli server command runs#1366cristipufu merged 1 commit intomainfrom
cristipufu merged 1 commit intomainfrom
Conversation
b72b0cf to
a3f5477
Compare
radu-mocanu
approved these changes
Feb 24, 2026
robert-ursu
approved these changes
Feb 24, 2026
- Replace global lock/baseline_env with _ServerState container - Clear and restore os.environ from server baseline between requests - Add early validation for environmentVariables type - Handle os.chdir errors inside the lock to avoid TOCTOU races - Protect finally-block chdir to ensure env is always restored - Add env isolation tests for sequential server requests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a3f5477 to
7170dda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.Lockto serialize command execution and prevent concurrentos.environmutationTest plan
environmentVariablespayloads and verify the second run does not see env vars from the first🤖 Generated with Claude Code