feat: gracefully handle unknown resource overwrites#1364
Merged
cotovanu-cristian merged 1 commit intomainfrom Feb 25, 2026
Merged
feat: gracefully handle unknown resource overwrites#1364cotovanu-cristian merged 1 commit intomainfrom
cotovanu-cristian merged 1 commit intomainfrom
Conversation
github-actions
bot
added
test:uipath-langchain
cotovanu-cristian
force-pushed
the
feat/handle-unknown-overwrites
branch
from
4ce542f to
bd5ccda
Compare
cotovanu-cristian
force-pushed
the
feat/handle-unknown-overwrites
branch
from
bd5ccda to
868a777
Compare
cristipufu
approved these changes
Feb 25, 2026
andreitava-uip
approved these changes
Feb 25, 2026
Comment on lines
+184
to
+191
| try: | ||
| overwrites_dict[key] = ResourceOverwriteParser.parse(key, value) | ||
| except Exception as e: | ||
| logger.warning( | ||
| "Skipping unrecognized resource overwrite '%s': %s", | ||
| key, | ||
| e, | ||
| ) |
Contributor
There was a problem hiding this comment.
my one gripe is that this will catch any and all exceptions, including validation issues for existing resource types. It's unclear how this will behave in those cases, it will probably fail down the line due to some other errors.
Since I think it's not introducing any regression and given the urgency it is probably fine, but we should revisit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary