feat(apollo-wind): comprehensive component stories update and cleanup#219
Draft
1980computer wants to merge 3 commits intomainfrom
Draft
feat(apollo-wind): comprehensive component stories update and cleanup#2191980computer wants to merge 3 commits intomainfrom
1980computer wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency ReviewThe following issues were found:
License Issuespackages/apollo-wind/package.json
pnpm-lock.yaml
OpenSSF ScorecardScorecard details
Scanned Files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| DropdownMenuTrigger, | ||
| } from './dropdown-menu'; | ||
| import type { EditableCellMeta } from './editable-cell'; | ||
| import { Input } from './input'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 days ago
General fix: Remove the unused import so the file only imports symbols that are actually used. This improves readability and avoids linter/static-analysis warnings without changing functionality.
Concrete best fix: In packages/apollo-wind/src/components/ui/data-table.stories.tsx, delete the Input named import line (import { Input } from './input';) while leaving all other imports unchanged. No other code edits or new imports are needed, since nothing in the shown code references Input.
Edit details:
- File:
packages/apollo-wind/src/components/ui/data-table.stories.tsx - Remove the line 37
import { Input } from './input';. - Ensure surrounding imports (before and after) remain exactly as they are.
Suggested changeset
1
packages/apollo-wind/src/components/ui/data-table.stories.tsx
| @@ -34,7 +34,6 @@ | ||
| DropdownMenuTrigger, | ||
| } from './dropdown-menu'; | ||
| import type { EditableCellMeta } from './editable-cell'; | ||
| import { Input } from './input'; | ||
| import { Label } from './label'; | ||
| import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from './select'; | ||
| import { Separator } from './separator'; |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Comment on lines
+2
to
+11
| import { | ||
| Calendar, | ||
| ExternalLink, | ||
| FileText, | ||
| GitBranch, | ||
| MapPin, | ||
| MoreHorizontal, | ||
| Star, | ||
| Users, | ||
| } from 'lucide-react'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 13 days ago
In general, unused imports should be removed so that every imported symbol is referenced somewhere in the file. This removes dead code, avoids confusion, and satisfies static analysis.
For this file, the best fix is to edit the destructuring import from lucide-react (lines 2–11) and delete only FileText and MoreHorizontal from the import list. No other code changes are needed, since we are not changing how any rendered story works—just removing unused symbols. We do not need any new imports or helper methods; we simply shorten the existing import list.
Concretely, in packages/apollo-wind/src/components/ui/hover-card.stories.tsx, modify the block:
import {
Calendar,
ExternalLink,
FileText,
GitBranch,
MapPin,
MoreHorizontal,
Star,
Users,
} from 'lucide-react';to:
import {
Calendar,
ExternalLink,
GitBranch,
MapPin,
Star,
Users,
} from 'lucide-react';leaving the rest of the file unchanged.
Suggested changeset
1
packages/apollo-wind/src/components/ui/hover-card.stories.tsx
| @@ -2,10 +2,8 @@ | ||
| import { | ||
| Calendar, | ||
| ExternalLink, | ||
| FileText, | ||
| GitBranch, | ||
| MapPin, | ||
| MoreHorizontal, | ||
| Star, | ||
| Users, | ||
| } from 'lucide-react'; |
Copilot is powered by AI and may make mistakes. Always verify output.
| @@ -1,72 +1,330 @@ | |||
| import type { Meta } from '@storybook/react-vite'; | |||
| import { Bell, CreditCard, Settings, Shield, User } from 'lucide-react'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 13 days ago
To fix unused imports, remove only the identifiers that are not used anywhere in the file, leaving the rest of the import statement intact. This preserves all existing functionality while cleaning up the module scope.
In this case, edit packages/apollo-wind/src/components/ui/tabs.stories.tsx, on the import line from lucide-react, and remove CreditCard and Settings from the destructuring list. The line:
import { Bell, CreditCard, Settings, Shield, User } from 'lucide-react';should be changed to:
import { Bell, Shield, User } from 'lucide-react';No additional methods, definitions, or imports are needed.
Suggested changeset
1
packages/apollo-wind/src/components/ui/tabs.stories.tsx
| @@ -1,5 +1,5 @@ | ||
| import type { Meta } from '@storybook/react-vite'; | ||
| import { Bell, CreditCard, Settings, Shield, User } from 'lucide-react'; | ||
| import { Bell, Shield, User } from 'lucide-react'; | ||
| import { Button } from './button'; | ||
| import { Card, CardContent, CardDescription, CardFooter, CardHeader, CardTitle } from './card'; | ||
| import { Input } from './input'; |
Copilot is powered by AI and may make mistakes. Always verify output.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+2
to
+11
| import { | ||
| Calendar, | ||
| ExternalLink, | ||
| FileText, | ||
| GitBranch, | ||
| MapPin, | ||
| MoreHorizontal, | ||
| Star, | ||
| Users, | ||
| } from 'lucide-react'; |
| @@ -1,72 +1,330 @@ | |||
| import type { Meta } from '@storybook/react-vite'; | |||
| import { Bell, CreditCard, Settings, Shield, User } from 'lucide-react'; | |||
| * Dark theme | ||
| * ============================================================================ */ | ||
|
|
||
| .legacy-dark { |
Collaborator
There was a problem hiding this comment.
this doesn't work.
We should use the same css vars and override based on the theme.
Not create new css vars with new names.
This makes adoption impossible.
Collaborator
CalinaCristian
left a comment
CalinaCristian
left a comment
There was a problem hiding this comment.
Please split changes into smaller PR's. This is very hard to review with those many changes.
CalinaCristian
requested changes
Feb 13, 2026
Collaborator
CalinaCristian
left a comment
CalinaCristian
left a comment
There was a problem hiding this comment.
not ready for merge.
CalinaCristian
changed the base branch from
main
to
feature/getting-started-only
CalinaCristian
changed the base branch from
feature/getting-started-only
to
main
CalinaCristian
force-pushed
the
feature/improve-templates-and-components
branch
from
feca31e to
b143a40
Compare
…g, and AI prototyping - Add Maestro, Delegate, Admin, and Flow template systems with multiple page variants (Landing, Dashboard, Settings, Data Management, Properties) - Implement dual-theme architecture: Future (dark/light) and Legacy (dark/light) with CSS custom properties and shadcn bridge pattern - Add custom components: MaestroHeader, FlowPanel, PropertiesSimple, PropertiesExpanded, Canvas, ChatComposer, and more - Create Prototyping documentation page with 5 tabs: Overview, Use Cases, Use Figma, Use AI, and Best Practices - Add apollo-ai-context.md — portable AI context file for consistent prototyping with LLMs (components, tokens, patterns, rules) - Install and configure @storybook/addon-mcp for live component metadata exposure to AI coding agents - Install and configure @storybook/addon-a11y for accessibility auditing - Hide addons panel by default, remove background switcher from toolbar - Reorganize Storybook sidebar: flatten Templates (remove Future folder), rename Current to Xrchive, rename Theme/Current to Theme/Legacy - Move legacy-theme.css to foundation/Future/ alongside future-theme.css - Upgrade all component stories to use Storybook categories - Delete deprecated example files and consolidate into new template system Co-authored-by: Cursor <cursoragent@cursor.com> feat(apollo-wind): add Getting Started section with templates, theming, and AI prototyping - Add Getting Started landing page and AI prototyping documentation - Implement Future theme system (dark/light) with CSS custom properties - Add gradient tokens (6 theme-aware gradients) to foundation - Create shared FutureTheme type for consistent theme prop typing - Add Onboarding, Agentic Process, and Empty & Errors template sections - Implement Flow template responsive panel behavior and properties panels - Add global theme sync for Radix portal components via preview decorator - Add aria-label and type="button" to all icon-only buttons for accessibility - Remove unused imports, functions, and dead code across story files - Delete legacy Xrchive templates (New Project, VSCode) Co-authored-by: Cursor <cursoragent@cursor.com>
Expand Storybook documentation with rich, structured stories for 20+ components following a consistent format (Basic, Variants, Examples). Reorganize component categories, remove unused components, and fix theme issues. Components updated: - Alert, Alert Dialog, Accordion, Badge, Breadcrumb, Combobox, Command, Context Menu, Data Table, Dialog, Dropdown, Empty State, Hover Card, Pagination, Popover, Progress, Sheet, Skeleton, Sonner/Toast, Spinner, Tabs, Tooltip Components removed: - Menubar, Navigation Menu (unused, not needed for design system) - Drawer (consolidated into Sheet/Drawer component) - Table stories (covered by Data Table) - Pattern Drawer/Modal experiments Reorganization: - Move Search, Calendar, Collapsible to UiPath-review folder - Move Alert, Spinner to Feedback category - Move Context Menu to Navigation category - Rename Sonner to Toast (Sonner), Dropdown Menu to Dropdown - Rename Sheet to Drawer (Sheet) Fixes: - Add --color-destructive-foreground to future-theme.css - Fix Context Menu forwardRef for right-click support - Enhance EmptyState with code prop and children support Co-authored-by: Cursor <cursoragent@cursor.com>
CalinaCristian
force-pushed
the
feature/improve-templates-and-components
branch
from
b143a40 to
20331ca
Compare
1980computer
force-pushed
the
feature/improve-templates-and-components
branch
from
20331ca to
871eedb
Compare
CalinaCristian
force-pushed
the
feature/improve-templates-and-components
branch
from
871eedb to
0e62f23
Compare
1980computer
force-pushed
the
feature/improve-templates-and-components
branch
4 times, most recently
from
0c4b6e7 to
6007acc
Compare
| DropdownMenuTrigger, | ||
| } from './dropdown-menu'; | ||
| import type { EditableCellMeta } from './editable-cell'; | ||
| import { Input } from './input'; |
1980computer
force-pushed
the
feature/improve-templates-and-components
branch
from
6007acc to
a05b48e
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
1980computer
force-pushed
the
feature/improve-templates-and-components
branch
from
a05b48e to
d23e3b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Components Updated
Alert, Alert Dialog, Accordion, Badge, Breadcrumb, Combobox, Command, Context Menu, Data Table, Dialog, Dropdown, Empty State, Hover Card, Pagination, Popover, Progress, Sheet (Drawer), Skeleton, Sonner (Toast), Spinner, Tabs, Tooltip
Components Removed
Reorganization
UiPath-reviewfolder for later evaluationFeedbackcategoryNavigationcategoryToast (Sonner)DropdownDrawer (Sheet)Fixes
--color-destructive-foregroundto future-theme.css (dark + light)forwardReffor right-click supportcodeprop andchildrensupport for flexible actionsTest plan
Made with Cursor