Conversation
mihairaduvlad
requested review from
MaxTranced,
adrianpetre and
irinel-birsan-uipath
MaxTranced
left a comment
MaxTranced
left a comment
There was a problem hiding this comment.
please double-check the versions in the file, maybe they can be made more consistent? Also, please double-check which branch this needs to be merged into.
| "description": "Backend server for the Computer Vision solution that detects User Interface Elements from a provided Application screenshot", | ||
| "displayName": "ComputerVision", | ||
| "gpu": 1, | ||
| "inputDescription": "Please use the Computer Vision Activities included in the UIAutomation package. For more information please visit the official documentation.", |
There was a problem hiding this comment.
Optional: Please include a link to the official documentation, you can see the messages used in the latest metadata files (for 23.10 for example).
| "minAIFabricVersion": "22.10", | ||
| "languageVersion": 3, | ||
| "version": 4, | ||
| "customVersion": "22.10.1", |
There was a problem hiding this comment.
Why is this 22.10.1 but above there is Release v2022.10.10? Can these versions match without any negative side-effects?
There was a problem hiding this comment.
I think you're right. I've changed to 22.10.10, since the same behaviour was also in 23.4/23.10.
@irinel-birsan-uipath can you please confirm that this is the correct way to do?
There was a problem hiding this comment.
we set it like minAIFabricVersion": "22.10",
Anyway, this is onlt informative, there is no check done on AIC side :(
MaxTranced
left a comment
MaxTranced
left a comment
There was a problem hiding this comment.
lgtm, don't forget about the branch comment above.
| "tenantName": "UiPath", | ||
| "minAIFabricVersion": "22.10", | ||
| "languageVersion": 3, | ||
| "version": 4, |
There was a problem hiding this comment.
Set version 9 here. Has to match with the number present in the filename to ensure that is different to other existing versions.
irinel-birsan-uipath
left a comment
irinel-birsan-uipath
left a comment
There was a problem hiding this comment.
merge to testing branch
3 participants
Linked with SF repo's PR: https://github.com/UiPath/service-fabric-packaging/pull/15387