Run MPI tests with Base.julia_cmd instead of Base.julia_exename#234
Merged
Run MPI tests with Base.julia_cmd instead of Base.julia_exename#234
Base.julia_cmd instead of Base.julia_exename#234Conversation
This ensures the same optimisation flags are passed to the processes we spawn, which affect cache invalidation.
Member
Author
|
Yes, jobs with Julia nightly are now successful 🙂 I reported the bug with broken precompilation of Sundials.jl at SciML/Sundials.jl#386. |
matt-graham
approved these changes
Feb 22, 2023
Member
matt-graham
left a comment
matt-graham
left a comment
There was a problem hiding this comment.
Looks good to merge to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the same optimisation flags are passed to the processes we spawn, which affect cache invalidation.
I noticed tests with Julia nightly in #233 were hanging. I believe the problem is the same as JuliaParallel/MPI.jl#706, which took me a while to debug, but at least I did it once and now I know what's the culprit.