Conversation
Updated the Azure file upload flow to pass overwrite=True so existing blobs are replaced when uploading and the remote URL remains captured. Adjusted the Azure file entity unit test to assert that the overwrite flag is supplied to upload_blob.
susrisha
requested changes
Sep 24, 2025
src/python_ms_core/core/storage/providers/azure/azure_file_entity.py
Outdated
Show resolved
Hide resolved
…nal overwrite flag so every storage provider exposes the same interface. - Adjusted the local file entity’s upload method to accept the new flag while keeping its upload behavior unchanged.
susrisha
approved these changes
Sep 24, 2025
susrisha
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests -
With override
Output
Without override
Output