Conversation
s-janel
left a comment
s-janel
left a comment
There was a problem hiding this comment.
I am not familiar with this data/data structure so this may or may not be relevant depending on use case, but my only comment would be to define flexible file paths
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
I have nothing new to say. I've looked over all the changes, and Ryan's pretty much nailed everything I'd say about this code.
CRC updated condensed code. 1 single function for both stratified and non stratified data.
MJC598
left a comment
MJC598
left a comment
There was a problem hiding this comment.
I defer to @ryan-odea with most of my comments but I do need stylistic formatting through stylr or air applied to the code just to keep consistent styles/indentations.
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
Looks very good! Just a very small ask to clean it up to be more 'tidyverse' style
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
Looks good! Great work 👍
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
I've looked it over again, and it looks terrific. Thanks for the edits!
5 participants
Updated the code for the Non-Stratified and Stratified CRC output